lints

`rustc` lints.
git clone https://git.philomathiclife.com/repos/lints
Log | Files | Refs | README

commit 488635712cb5c8f4a82453fd3b5c640c09624f6e
parent 22b6a7becdf1d892abbb55e329bb68485b975ec5
Author: Zack Newman <zack@philomathiclife.com>
Date:   Tue, 10 Mar 2026 17:40:47 -0600

update deps. add 1.94.0 output. slight cleanup of tests

Diffstat:
MCargo.toml | 13++++++++-----
Aoutputs/1.93.1.txt | 264+++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Aoutputs/1.94.0.txt | 269+++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Msrc/parse.rs | 37+++++++++++--------------------------
4 files changed, 552 insertions(+), 31 deletions(-)

diff --git a/Cargo.toml b/Cargo.toml @@ -9,8 +9,8 @@ license = "MIT OR Apache-2.0" name = "lints" readme = "README.md" repository = "https://git.philomathiclife.com/repos/lints/" -rust-version = "1.93.0" -version = "0.3.0" +rust-version = "1.93.1" +version = "0.3.1" [lints.rust] deprecated-safe = { level = "deny", priority = -1 } @@ -66,7 +66,6 @@ variant-size-differences = { level = "deny", priority = -1 } # Before publishing to crates.io, comment above and uncomment below. #warnings = { level = "allow", priority = -1 } #ambiguous-associated-items = { level = "allow", priority = -1 } -#ambiguous-glob-imports = { level = "allow", priority = -1 } #arithmetic-overflow = { level = "allow", priority = -1 } #binary-asm-labels = { level = "allow", priority = -1 } #bindings-with-variant-name = { level = "allow", priority = -1 } @@ -82,7 +81,6 @@ variant-size-differences = { level = "deny", priority = -1 } #incomplete-include = { level = "allow", priority = -1 } #ineffective-unstable-trait-impl = { level = "allow", priority = -1 } #invalid-atomic-ordering = { level = "allow", priority = -1 } -#invalid-doc-attributes = { level = "allow", priority = -1 } #invalid-from-utf8-unchecked = { level = "allow", priority = -1 } #invalid-macro-export-arguments = { level = "allow", priority = -1 } #invalid-null-arguments = { level = "allow", priority = -1 } @@ -136,6 +134,11 @@ single_call_fn = "allow" single_char_lifetime_names = "allow" unseparated_literal_suffix = "allow" +[lints.rustdoc] +# Before publishing to crates.io, comment below and uncomment below that. +all = { level = "deny", priority = -1 } +#all = "allow" + [package.metadata.docs.rs] default-target = "x86_64-unknown-linux-gnu" targets = [ @@ -152,7 +155,7 @@ targets = [ ] [target.'cfg(target_os = "openbsd")'.dependencies] -priv_sep = { version = "3.0.0-alpha.4.1", default-features = false, features = ["std"] } +priv_sep = { version = "3.0.0-alpha.5.0", default-features = false, features = ["std"] } [profile.release] codegen-units = 1 diff --git a/outputs/1.93.1.txt b/outputs/1.93.1.txt @@ -0,0 +1,264 @@ + +Available lint options: + -W <foo> Warn about <foo> + -A <foo> Allow <foo> + -D <foo> Deny <foo> + -F <foo> Forbid <foo> (deny <foo> and all attempts to override) + + +Lint checks provided by rustc: + + name default meaning + ---- ------- ------- + absolute-paths-not-starting-with-crate allow fully qualified paths that start with a module name instead of `crate`, `self`, or an extern crate name + ambiguous-negative-literals allow ambiguous negative literals operations + closure-returning-async-block allow closure that returns `async {}` could be rewritten as an async closure + deprecated-in-future allow detects use of items that will be deprecated in a future version + deprecated-safe-2024 allow detects unsafe functions being used as safe functions + deref-into-dyn-supertrait allow `Deref` implementation with a supertrait trait object for output is shadowed by trait upcasting + edition-2024-expr-fragment-specifier allow The `expr` fragment specifier will accept more expressions in the 2024 edition. To keep the existing behavior, use the `expr_2021` fragment specifier. + elided-lifetimes-in-paths allow hidden lifetime parameters in types are deprecated + explicit-outlives-requirements allow outlives requirements can be inferred + ffi-unwind-calls allow call to foreign functions or function pointers with FFI-unwind ABI + fuzzy-provenance-casts allow a fuzzy integer to pointer cast is used + if-let-rescope allow `if let` assigns a shorter lifetime to temporary values being pattern-matched against in Edition 2024 and rewriting in `match` is an option to preserve the semantics up to Edition 2021 + impl-trait-overcaptures allow `impl Trait` will capture more lifetimes than possibly intended in edition 2024 + impl-trait-redundant-captures allow redundant precise-capturing `use<...>` syntax on an `impl Trait` + keyword-idents-2018 allow detects edition keywords being used as an identifier + keyword-idents-2024 allow detects edition keywords being used as an identifier + let-underscore-drop allow non-binding let on a type that has a destructor + linker-messages allow warnings emitted at runtime by the target-specific linker program + lossy-provenance-casts allow a lossy pointer to integer cast is used + macro-use-extern-crate allow the `#[macro_use]` attribute is now deprecated in favor of using macros via the module system + meta-variable-misuse allow possible meta-variable misuse at macro definition + missing-copy-implementations allow detects potentially-forgotten implementations of `Copy` + missing-debug-implementations allow detects missing implementations of Debug + missing-docs allow detects missing documentation for public members + missing-unsafe-on-extern allow detects missing unsafe keyword on extern declarations + multiple-supertrait-upcastable allow detect when a dyn-compatible trait has multiple supertraits + must-not-suspend allow use of a `#[must_not_suspend]` value across a yield point + non-ascii-idents allow detects non-ASCII identifiers + non-exhaustive-omitted-patterns allow detect when patterns of types marked `non_exhaustive` are missed + redundant-imports allow imports that are redundant due to being imported already + redundant-lifetimes allow detects lifetime parameters that are redundant because they are equal to some other named lifetime + resolving-to-items-shadowing-supertrait-items allow detects when a supertrait item is shadowed by a subtrait item + rust-2021-incompatible-closure-captures allow detects closures affected by Rust 2021 changes + rust-2021-incompatible-or-patterns allow detects usage of old versions of or-patterns + rust-2021-prefixes-incompatible-syntax allow identifiers that will be parsed as a prefix in Rust 2021 + rust-2021-prelude-collisions allow detects the usage of trait methods which are ambiguous with traits added to the prelude in future editions + rust-2024-guarded-string-incompatible-syntax allow will be parsed as a guarded string in Rust 2024 + rust-2024-incompatible-pat allow detects patterns whose meaning will change in Rust 2024 + rust-2024-prelude-collisions allow detects the usage of trait methods which are ambiguous with traits added to the prelude in future editions + shadowing-supertrait-items allow detects when a supertrait item is shadowed by a subtrait item + single-use-lifetimes allow detects lifetime parameters that are only used once + tail-expr-drop-order allow Detect and warn on significant change in drop order in tail expression location + trivial-casts allow detects trivial casts which could be removed + trivial-numeric-casts allow detects trivial casts of numeric types which could be removed + unit-bindings allow binding is useless because it has the unit `()` type + unnameable-types allow effective visibility of a type is larger than the area in which it can be named + unqualified-local-imports allow `use` of a local item without leading `self::`, `super::`, or `crate::` + unreachable-pub allow `pub` items not reachable from crate root + unsafe-attr-outside-unsafe allow detects unsafe attributes outside of unsafe + unsafe-code allow usage of `unsafe` code and other potentially unsound constructs + unsafe-op-in-unsafe-fn allow unsafe operations in unsafe functions without an explicit unsafe block are deprecated + unstable-features allow enabling unstable features + unused-crate-dependencies allow crate dependencies that are never used + unused-extern-crates allow extern crates that are never used + unused-import-braces allow unnecessary braces around an imported item + unused-lifetimes allow detects lifetime parameters that are never used + unused-macro-rules allow detects macro rules that were not used + unused-qualifications allow detects unnecessarily qualified names + unused-results allow unused result of an expression in a statement + variant-size-differences allow detects enums with widely varying variant sizes + aarch64-softfloat-neon warn detects code that could be affected by ABI issues on aarch64 softfloat targets + ambiguous-glob-reexports warn ambiguous glob re-exports + ambiguous-wide-pointer-comparisons warn detects ambiguous wide pointer comparisons + anonymous-parameters warn detects anonymous parameters + array-into-iter warn detects calling `into_iter` on arrays in Rust 2015 and 2018 + asm-sub-register warn using only a subset of a register for inline asm inputs + async-fn-in-trait warn use of `async fn` in definition of a publicly-reachable trait + bad-asm-style warn incorrect use of inline assembly + bare-trait-objects warn suggest using `dyn Trait` for trait objects + boxed-slice-into-iter warn detects calling `into_iter` on boxed slices in Rust 2015, 2018, and 2021 + break-with-label-and-loop warn `break` expression with label and unlabeled loop as value expression + clashing-extern-declarations warn detects when an extern fn has been declared with the same name but different types + coherence-leak-check warn distinct impls distinguished only by the leak-check code + confusable-idents warn detects visually confusable pairs between identifiers + const-evaluatable-unchecked warn detects a generic constant is used in a type without a emitting a warning + const-item-interior-mutations warn checks for calls which mutates a interior mutable const-item + const-item-mutation warn detects attempts to mutate a `const` item + dangling-pointers-from-locals warn detects returning a pointer from a local variable + dangling-pointers-from-temporaries warn detects getting a pointer from a temporary + dead-code warn detect unused, unexported items + deprecated warn detects use of deprecated items + deprecated-where-clause-location warn deprecated where clause location + double-negations warn detects expressions of the form `--x` + dropping-copy-types warn calls to `std::mem::drop` with a value that implements Copy + dropping-references warn calls to `std::mem::drop` with a reference instead of an owned value + drop-bounds warn bounds of the form `T: Drop` are most likely incorrect + duplicate-macro-attributes warn duplicated attribute + dyn-drop warn trait objects of the form `dyn Drop` are useless + ellipsis-inclusive-range-patterns warn `...` range patterns are deprecated + exported-private-dependencies warn public interface leaks type from a private dependency + forbidden-lint-groups warn applying forbid to lint-groups + forgetting-copy-types warn calls to `std::mem::forget` with a value that implements Copy + forgetting-references warn calls to `std::mem::forget` with a reference instead of an owned value + for-loops-over-fallibles warn for-looping over an `Option` or a `Result`, which is more clearly expressed as an `if let` + function-casts-as-integer warn casting a function into an integer + function-item-references warn suggest casting to a function pointer when attempting to take references to function items + hidden-glob-reexports warn name introduced by a private item shadows a name introduced by a public glob re-export + improper-ctypes warn proper use of libc types in foreign modules + improper-ctypes-definitions warn proper use of libc types in foreign item definitions + incomplete-features warn incomplete features that may function improperly in some or all cases + inline-no-sanitize warn detects incompatible use of `#[inline(always)]` and `#[sanitize(... = "off")]` + integer-to-ptr-transmutes warn detects integer to pointer transmutes + internal-features warn internal features are not supposed to be used + invalid-from-utf8 warn using a non UTF-8 literal in `std::str::from_utf8` + invalid-nan-comparisons warn detects invalid floating point NaN comparisons + invalid-value warn an invalid value is being created (such as a null reference) + irrefutable-let-patterns warn detects irrefutable patterns in `if let` and `while let` statements + large-assignments warn detects large moves or copies + late-bound-lifetime-arguments warn detects generic lifetime arguments in path segments with late bound lifetime parameters + malformed-diagnostic-attributes warn detects malformed diagnostic attributes + malformed-diagnostic-format-literals warn detects diagnostic attribute with malformed diagnostic format literals + map-unit-fn warn `Iterator::map` call that discard the iterator's values + mismatched-lifetime-syntaxes warn detects when a lifetime uses different syntax between arguments and return values + misplaced-diagnostic-attributes warn detects diagnostic attributes that are placed on the wrong item + missing-abi warn No declared ABI for extern declaration + mixed-script-confusables warn detects Unicode scripts whose mixed script confusables codepoints are solely used + named-arguments-used-positionally warn named arguments in format used positionally + non-camel-case-types warn types, variants, traits and type parameters should have camel case names + non-contiguous-range-endpoints warn detects off-by-one errors with exclusive range patterns + non-fmt-panics warn detect single-argument panic!() invocations in which the argument is not a format string + non-local-definitions warn checks for non-local definitions + non-shorthand-field-patterns warn using `Struct { x: x }` instead of `Struct { x }` in a pattern + non-snake-case warn variables, methods, functions, lifetime parameters and modules should have snake case names + non-upper-case-globals warn static constants should have uppercase identifiers + noop-method-call warn detects the use of well-known noop methods + no-mangle-generic-items warn generic items must be mangled + opaque-hidden-inferred-bound warn detects the use of nested `impl Trait` types in associated type bounds that are not general enough + overlapping-range-endpoints warn detects range patterns with overlapping endpoints + path-statements warn path statements with no effect + private-bounds warn private type in secondary interface of an item + private-interfaces warn private type in primary interface of an item + ptr-to-integer-transmute-in-consts warn detects pointer to integer transmutes in const functions and associated constants + redundant-semicolons warn detects unnecessary trailing semicolons + refining-impl-trait-internal warn impl trait in impl method signature does not match trait method signature + refining-impl-trait-reachable warn impl trait in impl method signature does not match trait method signature + renamed-and-removed-lints warn lints that have been renamed or removed + repr-c-enums-larger-than-int warn repr(C) enums with discriminant values that do not fit into a C int + rtsan-nonblocking-async warn detects incompatible uses of `#[sanitize(realtime = "nonblocking")]` on async functions + self-constructor-from-outer-item warn detect unsupported use of `Self` from outer item + special-module-name warn module declarations for files with a special meaning + stable-features warn stable features found in `#[feature]` directive + static-mut-refs warn creating a shared reference to mutable static + suspicious-double-ref-op warn suspicious call of trait method on `&&T` + trivial-bounds warn these bounds don't depend on an type parameters + type-alias-bounds warn bounds in type aliases are not enforced + tyvar-behind-raw-pointer warn raw pointer to an inference variable + uncommon-codepoints warn detects uncommon Unicode codepoints in identifiers + unconditional-recursion warn functions that cannot return without calling themselves + uncovered-param-in-projection warn impl contains type parameters that are not covered + unexpected-cfgs warn detects unexpected names and values in `#[cfg]` conditions + unfulfilled-lint-expectations warn unfulfilled lint expectation + ungated-async-fn-track-caller warn enabling track_caller on an async fn is a no-op unless the async_fn_track_caller feature is enabled + uninhabited-static warn uninhabited static + unknown-diagnostic-attributes warn detects unknown diagnostic attributes + unknown-lints warn unrecognized lint attribute + unnameable-test-items warn detects an item that cannot be named being marked as `#[test_case]` + unnecessary-transmutes warn detects transmutes that can also be achieved by other operations + unpredictable-function-pointer-comparisons warn detects unpredictable function pointer comparisons + unreachable-code warn detects unreachable code paths + unreachable-patterns warn detects unreachable patterns + unstable-name-collisions warn detects name collision with an existing but unstable method + unstable-syntax-pre-expansion warn unstable syntax can change at any point in the future, causing a hard error! + unsupported-calling-conventions warn use of unsupported calling convention + unused-allocation warn detects unnecessary allocations that can be eliminated + unused-assignments warn detect assignments that will never be read + unused-associated-type-bounds warn detects unused `Foo = Bar` bounds in `dyn Trait<Foo = Bar>` + unused-attributes warn detects attributes that were not used by the compiler + unused-braces warn unnecessary braces around an expression + unused-comparisons warn comparisons made useless by limits of the types involved + unused-doc-comments warn detects doc comments that aren't used by rustdoc + unused-features warn unused features found in crate-level `#[feature]` directives + unused-imports warn imports that are never used + unused-labels warn detects labels that are never used + unused-macros warn detects macros that were not used + unused-must-use warn unused result of a type flagged as `#[must_use]` + unused-mut warn detect mut variables which don't need to be mutable + unused-parens warn `if`, `match`, `while` and `return` do not need parentheses + unused-unsafe warn unnecessary use of an `unsafe` block + unused-variables warn detect variables which are not used in any way + useless-ptr-null-checks warn useless checking of non-null-typed pointer + uses-power-alignment warn Structs do not follow the power alignment rule under repr(C) + varargs-without-pattern warn detects usage of `...` arguments without a pattern in non-foreign items + warnings warn mass-change the level for lints which produce warnings + while-true warn suggest using `loop { }` instead of `while true { }` + ambiguous-associated-items deny ambiguous associated items + ambiguous-glob-imports deny detects certain glob imports that require reporting an ambiguity error + arithmetic-overflow deny arithmetic operation overflows + binary-asm-labels deny labels in inline assembly containing only 0 or 1 digits + bindings-with-variant-name deny detects pattern bindings with the same name as one of the matched variants + conflicting-repr-hints deny conflicts between `#[repr(..)]` hints that were previously accepted and used in practice + dangerous-implicit-autorefs deny implicit reference to a dereference of a raw pointer + default-overrides-default-fields deny detect `Default` impl that should use the type's default field values + dependency-on-unit-never-type-fallback deny never type fallback affecting unsafe function calls + deref-nullptr deny detects when an null pointer is dereferenced + elided-lifetimes-in-associated-constant deny elided lifetimes cannot be used in associated constants in impls + enum-intrinsics-non-enums deny detects calls to `core::mem::discriminant` and `core::mem::variant_count` with non-enum types + explicit-builtin-cfgs-in-flags deny detects builtin cfgs set via the `--cfg` + ill-formed-attribute-input deny ill-formed attribute inputs that were previously accepted and used in practice + incomplete-include deny trailing content in included file + ineffective-unstable-trait-impl deny detects `#[unstable]` on stable trait implementations for stable types + invalid-atomic-ordering deny usage of invalid atomic ordering in atomic operations and memory fences + invalid-doc-attributes deny detects invalid `#[doc(...)]` attributes + invalid-from-utf8-unchecked deny using a non UTF-8 literal in `std::str::from_utf8_unchecked` + invalid-macro-export-arguments deny "invalid_parameter" isn't a valid argument for `#[macro_export]` + invalid-null-arguments deny invalid null pointer in arguments + invalid-reference-casting deny casts of `&T` to `&mut T` without interior mutability + invalid-type-param-default deny type parameter default erroneously allowed in invalid location + legacy-derive-helpers deny detects derive helper attributes that are used before they are introduced + let-underscore-lock deny non-binding let on a synchronization lock + long-running-const-eval deny detects long const eval operations + macro-expanded-macro-exports-accessed-by-absolute-paths deny macro-expanded `macro_export` macros from the current crate cannot be referred to by absolute paths + mutable-transmutes deny transmuting &T to &mut T is undefined behavior, even if the reference is unused + named-asm-labels deny named labels in inline assembly + never-type-fallback-flowing-into-unsafe deny never type fallback affecting unsafe function calls + no-mangle-const-items deny const items will not have their symbols exported + out-of-scope-macro-calls deny detects out of scope calls to `macro_rules` in key-value attributes + overflowing-literals deny literal out of range for its type + patterns-in-fns-without-body deny patterns in functions without body were erroneously allowed + proc-macro-derive-resolution-fallback deny detects proc macro derives using inaccessible names from parent modules + pub-use-of-private-extern-crate deny detect public re-exports of private extern crates + repr-transparent-non-zst-fields deny transparent type contains an external ZST that is marked #[non_exhaustive] or contains private fields + semicolon-in-expressions-from-macros deny trailing semicolon in macro body used as expression + soft-unstable deny a feature gate that doesn't break dependent crates + test-unstable-lint deny this unstable lint is only for testing + text-direction-codepoint-in-comment deny invisible directionality-changing codepoints in comment + text-direction-codepoint-in-literal deny detect special Unicode codepoints that affect the visual representation of text on screen, changing the direction in which text flows + unconditional-panic deny operation will cause a panic at runtime + undropped-manually-drops deny calls to `std::mem::drop` with `std::mem::ManuallyDrop` instead of it's inner value + unknown-crate-types deny unknown crate type found in `#[crate_type]` directive + useless-deprecated deny detects deprecation attributes with no effect + + +Lint groups provided by rustc: + + name sub-lints + ---- --------- + warnings all lints that are set to issue warnings + deprecated-safe deprecated-safe-2024 + future-incompatible aarch64-softfloat-neon, ambiguous-associated-items, ambiguous-glob-imports, coherence-leak-check, conflicting-repr-hints, const-evaluatable-unchecked, elided-lifetimes-in-associated-constant, forbidden-lint-groups, ill-formed-attribute-input, invalid-macro-export-arguments, invalid-type-param-default, late-bound-lifetime-arguments, legacy-derive-helpers, macro-expanded-macro-exports-accessed-by-absolute-paths, out-of-scope-macro-calls, patterns-in-fns-without-body, proc-macro-derive-resolution-fallback, pub-use-of-private-extern-crate, repr-c-enums-larger-than-int, repr-transparent-non-zst-fields, self-constructor-from-outer-item, semicolon-in-expressions-from-macros, soft-unstable, uncovered-param-in-projection, uninhabited-static, unstable-name-collisions, unstable-syntax-pre-expansion, unsupported-calling-conventions, varargs-without-pattern + keyword-idents keyword-idents-2018, keyword-idents-2024 + let-underscore let-underscore-drop, let-underscore-lock + nonstandard-style non-camel-case-types, non-snake-case, non-upper-case-globals + refining-impl-trait refining-impl-trait-reachable, refining-impl-trait-internal + rust-2018-compatibility keyword-idents-2018, anonymous-parameters, absolute-paths-not-starting-with-crate, tyvar-behind-raw-pointer + rust-2018-idioms bare-trait-objects, unused-extern-crates, ellipsis-inclusive-range-patterns, elided-lifetimes-in-paths, explicit-outlives-requirements + rust-2021-compatibility ellipsis-inclusive-range-patterns, array-into-iter, non-fmt-panics, bare-trait-objects, rust-2021-incompatible-closure-captures, rust-2021-incompatible-or-patterns, rust-2021-prefixes-incompatible-syntax, rust-2021-prelude-collisions + rust-2024-compatibility keyword-idents-2024, edition-2024-expr-fragment-specifier, boxed-slice-into-iter, impl-trait-overcaptures, if-let-rescope, static-mut-refs, dependency-on-unit-never-type-fallback, deprecated-safe-2024, missing-unsafe-on-extern, never-type-fallback-flowing-into-unsafe, rust-2024-guarded-string-incompatible-syntax, rust-2024-incompatible-pat, rust-2024-prelude-collisions, tail-expr-drop-order, unsafe-attr-outside-unsafe, unsafe-op-in-unsafe-fn + unknown-or-malformed-diagnostic-attributes malformed-diagnostic-attributes, malformed-diagnostic-format-literals, misplaced-diagnostic-attributes, unknown-diagnostic-attributes + unused unused-imports, unused-variables, unused-assignments, dead-code, unused-mut, unreachable-code, unreachable-patterns, unused-must-use, unused-unsafe, path-statements, unused-attributes, unused-macros, unused-macro-rules, unused-allocation, unused-doc-comments, unused-extern-crates, unused-features, unused-labels, unused-parens, unused-braces, redundant-semicolons, map-unit-fn + + +Lint tools like Clippy can load additional lints and lint groups. diff --git a/outputs/1.94.0.txt b/outputs/1.94.0.txt @@ -0,0 +1,269 @@ + +Available lint options: + -W <foo> Warn about <foo> + -A <foo> Allow <foo> + -D <foo> Deny <foo> + -F <foo> Forbid <foo> (deny <foo> and all attempts to override) + + +Lint checks provided by rustc: + + name default meaning + ---- ------- ------- + absolute-paths-not-starting-with-crate allow fully qualified paths that start with a module name instead of `crate`, `self`, or an extern crate name + ambiguous-negative-literals allow ambiguous negative literals operations + closure-returning-async-block allow closure that returns `async {}` could be rewritten as an async closure + deprecated-in-future allow detects use of items that will be deprecated in a future version + deprecated-safe-2024 allow detects unsafe functions being used as safe functions + deref-into-dyn-supertrait allow `Deref` implementation with a supertrait trait object for output is shadowed by trait upcasting + edition-2024-expr-fragment-specifier allow The `expr` fragment specifier will accept more expressions in the 2024 edition. To keep the existing behavior, use the `expr_2021` fragment specifier. + elided-lifetimes-in-paths allow hidden lifetime parameters in types are deprecated + explicit-outlives-requirements allow outlives requirements can be inferred + ffi-unwind-calls allow call to foreign functions or function pointers with FFI-unwind ABI + fuzzy-provenance-casts allow a fuzzy integer to pointer cast is used + if-let-rescope allow `if let` assigns a shorter lifetime to temporary values being pattern-matched against in Edition 2024 and rewriting in `match` is an option to preserve the semantics up to Edition 2021 + impl-trait-overcaptures allow `impl Trait` will capture more lifetimes than possibly intended in edition 2024 + impl-trait-redundant-captures allow redundant precise-capturing `use<...>` syntax on an `impl Trait` + keyword-idents-2018 allow detects edition keywords being used as an identifier + keyword-idents-2024 allow detects edition keywords being used as an identifier + let-underscore-drop allow non-binding let on a type that has a destructor + linker-messages allow warnings emitted at runtime by the target-specific linker program + lossy-provenance-casts allow a lossy pointer to integer cast is used + macro-use-extern-crate allow the `#[macro_use]` attribute is now deprecated in favor of using macros via the module system + meta-variable-misuse allow possible meta-variable misuse at macro definition + missing-copy-implementations allow detects potentially-forgotten implementations of `Copy` + missing-debug-implementations allow detects missing implementations of Debug + missing-docs allow detects missing documentation for public members + missing-unsafe-on-extern allow detects missing unsafe keyword on extern declarations + multiple-supertrait-upcastable allow detect when a dyn-compatible trait has multiple supertraits + must-not-suspend allow use of a `#[must_not_suspend]` value across a yield point + non-ascii-idents allow detects non-ASCII identifiers + non-exhaustive-omitted-patterns allow detect when patterns of types marked `non_exhaustive` are missed + redundant-imports allow imports that are redundant due to being imported already + redundant-lifetimes allow detects lifetime parameters that are redundant because they are equal to some other named lifetime + resolving-to-items-shadowing-supertrait-items allow detects when a supertrait item is shadowed by a subtrait item + rust-2021-incompatible-closure-captures allow detects closures affected by Rust 2021 changes + rust-2021-incompatible-or-patterns allow detects usage of old versions of or-patterns + rust-2021-prefixes-incompatible-syntax allow identifiers that will be parsed as a prefix in Rust 2021 + rust-2021-prelude-collisions allow detects the usage of trait methods which are ambiguous with traits added to the prelude in future editions + rust-2024-guarded-string-incompatible-syntax allow will be parsed as a guarded string in Rust 2024 + rust-2024-incompatible-pat allow detects patterns whose meaning will change in Rust 2024 + rust-2024-prelude-collisions allow detects the usage of trait methods which are ambiguous with traits added to the prelude in future editions + shadowing-supertrait-items allow detects when a supertrait item is shadowed by a subtrait item + single-use-lifetimes allow detects lifetime parameters that are only used once + tail-expr-drop-order allow Detect and warn on significant change in drop order in tail expression location + trivial-casts allow detects trivial casts which could be removed + trivial-numeric-casts allow detects trivial casts of numeric types which could be removed + unit-bindings allow binding is useless because it has the unit `()` type + unnameable-types allow effective visibility of a type is larger than the area in which it can be named + unqualified-local-imports allow `use` of a local item without leading `self::`, `super::`, or `crate::` + unreachable-pub allow `pub` items not reachable from crate root + unsafe-attr-outside-unsafe allow detects unsafe attributes outside of unsafe + unsafe-code allow usage of `unsafe` code and other potentially unsound constructs + unsafe-op-in-unsafe-fn allow unsafe operations in unsafe functions without an explicit unsafe block are deprecated + unstable-features allow enabling unstable features + unused-crate-dependencies allow crate dependencies that are never used + unused-extern-crates allow extern crates that are never used + unused-import-braces allow unnecessary braces around an imported item + unused-lifetimes allow detects lifetime parameters that are never used + unused-macro-rules allow detects macro rules that were not used + unused-qualifications allow detects unnecessarily qualified names + unused-results allow unused result of an expression in a statement + variant-size-differences allow detects enums with widely varying variant sizes + aarch64-softfloat-neon warn detects code that could be affected by ABI issues on aarch64 softfloat targets + ambiguous-glob-imports warn detects certain glob imports that require reporting an ambiguity error + ambiguous-glob-reexports warn ambiguous glob re-exports + ambiguous-panic-imports warn detects ambiguous core and std panic imports + ambiguous-wide-pointer-comparisons warn detects ambiguous wide pointer comparisons + anonymous-parameters warn detects anonymous parameters + array-into-iter warn detects calling `into_iter` on arrays in Rust 2015 and 2018 + asm-sub-register warn using only a subset of a register for inline asm inputs + async-fn-in-trait warn use of `async fn` in definition of a publicly-reachable trait + bad-asm-style warn incorrect use of inline assembly + bare-trait-objects warn suggest using `dyn Trait` for trait objects + boxed-slice-into-iter warn detects calling `into_iter` on boxed slices in Rust 2015, 2018, and 2021 + break-with-label-and-loop warn `break` expression with label and unlabeled loop as value expression + clashing-extern-declarations warn detects when an extern fn has been declared with the same name but different types + coherence-leak-check warn distinct impls distinguished only by the leak-check code + confusable-idents warn detects visually confusable pairs between identifiers + const-evaluatable-unchecked warn detects a generic constant is used in a type without a emitting a warning + const-item-interior-mutations warn checks for calls which mutates a interior mutable const-item + const-item-mutation warn detects attempts to mutate a `const` item + dangling-pointers-from-locals warn detects returning a pointer from a local variable + dangling-pointers-from-temporaries warn detects getting a pointer from a temporary + dead-code warn detect unused, unexported items + deprecated warn detects use of deprecated items + deprecated-where-clause-location warn deprecated where clause location + double-negations warn detects expressions of the form `--x` + dropping-copy-types warn calls to `std::mem::drop` with a value that implements Copy + dropping-references warn calls to `std::mem::drop` with a reference instead of an owned value + drop-bounds warn bounds of the form `T: Drop` are most likely incorrect + duplicate-macro-attributes warn duplicated attribute + dyn-drop warn trait objects of the form `dyn Drop` are useless + ellipsis-inclusive-range-patterns warn `...` range patterns are deprecated + exported-private-dependencies warn public interface leaks type from a private dependency + forbidden-lint-groups warn applying forbid to lint-groups + forgetting-copy-types warn calls to `std::mem::forget` with a value that implements Copy + forgetting-references warn calls to `std::mem::forget` with a reference instead of an owned value + for-loops-over-fallibles warn for-looping over an `Option` or a `Result`, which is more clearly expressed as an `if let` + function-casts-as-integer warn casting a function into an integer + function-item-references warn suggest casting to a function pointer when attempting to take references to function items + hidden-glob-reexports warn name introduced by a private item shadows a name introduced by a public glob re-export + improper-ctypes warn proper use of libc types in foreign modules + improper-ctypes-definitions warn proper use of libc types in foreign item definitions + improper-gpu-kernel-arg warn GPU kernel entry points have a limited ABI + incomplete-features warn incomplete features that may function improperly in some or all cases + inline-always-mismatching-target-features warn detects when a function annotated with `#[inline(always)]` and `#[target_feature(enable = "..")]` is inlined into a caller without the required target feature + inline-no-sanitize warn detects incompatible use of `#[inline(always)]` and `#[sanitize(... = "off")]` + integer-to-ptr-transmutes warn detects integer to pointer transmutes + internal-features warn internal features are not supposed to be used + invalid-doc-attributes warn detects invalid `#[doc(...)]` attributes + invalid-from-utf8 warn using a non UTF-8 literal in `std::str::from_utf8` + invalid-nan-comparisons warn detects invalid floating point NaN comparisons + invalid-value warn an invalid value is being created (such as a null reference) + irrefutable-let-patterns warn detects irrefutable patterns in `if let` and `while let` statements + large-assignments warn detects large moves or copies + late-bound-lifetime-arguments warn detects generic lifetime arguments in path segments with late bound lifetime parameters + malformed-diagnostic-attributes warn detects malformed diagnostic attributes + malformed-diagnostic-format-literals warn detects diagnostic attribute with malformed diagnostic format literals + map-unit-fn warn `Iterator::map` call that discard the iterator's values + mismatched-lifetime-syntaxes warn detects when a lifetime uses different syntax between arguments and return values + misplaced-diagnostic-attributes warn detects diagnostic attributes that are placed on the wrong item + missing-abi warn No declared ABI for extern declaration + missing-gpu-kernel-export-name warn mangled gpu-kernel function + mixed-script-confusables warn detects Unicode scripts whose mixed script confusables codepoints are solely used + named-arguments-used-positionally warn named arguments in format used positionally + non-camel-case-types warn types, variants, traits and type parameters should have camel case names + non-contiguous-range-endpoints warn detects off-by-one errors with exclusive range patterns + non-fmt-panics warn detect single-argument panic!() invocations in which the argument is not a format string + non-local-definitions warn checks for non-local definitions + non-shorthand-field-patterns warn using `Struct { x: x }` instead of `Struct { x }` in a pattern + non-snake-case warn variables, methods, functions, lifetime parameters and modules should have snake case names + non-upper-case-globals warn static constants should have uppercase identifiers + noop-method-call warn detects the use of well-known noop methods + no-mangle-generic-items warn generic items must be mangled + opaque-hidden-inferred-bound warn detects the use of nested `impl Trait` types in associated type bounds that are not general enough + overlapping-range-endpoints warn detects range patterns with overlapping endpoints + path-statements warn path statements with no effect + private-bounds warn private type in secondary interface of an item + private-interfaces warn private type in primary interface of an item + ptr-to-integer-transmute-in-consts warn detects pointer to integer transmutes in const functions and associated constants + redundant-semicolons warn detects unnecessary trailing semicolons + refining-impl-trait-internal warn impl trait in impl method signature does not match trait method signature + refining-impl-trait-reachable warn impl trait in impl method signature does not match trait method signature + renamed-and-removed-lints warn lints that have been renamed or removed + repr-c-enums-larger-than-int warn repr(C) enums with discriminant values that do not fit into a C int + rtsan-nonblocking-async warn detects incompatible uses of `#[sanitize(realtime = "nonblocking")]` on async functions + self-constructor-from-outer-item warn detect unsupported use of `Self` from outer item + special-module-name warn module declarations for files with a special meaning + stable-features warn stable features found in `#[feature]` directive + static-mut-refs warn creating a shared reference to mutable static + suspicious-double-ref-op warn suspicious call of trait method on `&&T` + trivial-bounds warn these bounds don't depend on an type parameters + type-alias-bounds warn bounds in type aliases are not enforced + tyvar-behind-raw-pointer warn raw pointer to an inference variable + uncommon-codepoints warn detects uncommon Unicode codepoints in identifiers + unconditional-recursion warn functions that cannot return without calling themselves + uncovered-param-in-projection warn impl contains type parameters that are not covered + unexpected-cfgs warn detects unexpected names and values in `#[cfg]` conditions + unfulfilled-lint-expectations warn unfulfilled lint expectation + ungated-async-fn-track-caller warn enabling track_caller on an async fn is a no-op unless the async_fn_track_caller feature is enabled + uninhabited-static warn uninhabited static + unknown-diagnostic-attributes warn detects unknown diagnostic attributes + unknown-lints warn unrecognized lint attribute + unnameable-test-items warn detects an item that cannot be named being marked as `#[test_case]` + unnecessary-transmutes warn detects transmutes that can also be achieved by other operations + unpredictable-function-pointer-comparisons warn detects unpredictable function pointer comparisons + unreachable-code warn detects unreachable code paths + unreachable-patterns warn detects unreachable patterns + unstable-name-collisions warn detects name collision with an existing but unstable method + unstable-syntax-pre-expansion warn unstable syntax can change at any point in the future, causing a hard error! + unsupported-calling-conventions warn use of unsupported calling convention + unused-allocation warn detects unnecessary allocations that can be eliminated + unused-assignments warn detect assignments that will never be read + unused-associated-type-bounds warn detects unused `Foo = Bar` bounds in `dyn Trait<Foo = Bar>` + unused-attributes warn detects attributes that were not used by the compiler + unused-braces warn unnecessary braces around an expression + unused-comparisons warn comparisons made useless by limits of the types involved + unused-doc-comments warn detects doc comments that aren't used by rustdoc + unused-features warn unused features found in crate-level `#[feature]` directives + unused-imports warn imports that are never used + unused-labels warn detects labels that are never used + unused-macros warn detects macros that were not used + unused-must-use warn unused result of a type flagged as `#[must_use]` + unused-mut warn detect mut variables which don't need to be mutable + unused-parens warn `if`, `match`, `while` and `return` do not need parentheses + unused-unsafe warn unnecessary use of an `unsafe` block + unused-variables warn detect variables which are not used in any way + unused-visibilities warn detect visibility qualifiers on `const _` items + useless-ptr-null-checks warn useless checking of non-null-typed pointer + uses-power-alignment warn Structs do not follow the power alignment rule under repr(C) + varargs-without-pattern warn detects usage of `...` arguments without a pattern in non-foreign items + warnings warn mass-change the level for lints which produce warnings + while-true warn suggest using `loop { }` instead of `while true { }` + ambiguous-associated-items deny ambiguous associated items + arithmetic-overflow deny arithmetic operation overflows + binary-asm-labels deny labels in inline assembly containing only 0 or 1 digits + bindings-with-variant-name deny detects pattern bindings with the same name as one of the matched variants + conflicting-repr-hints deny conflicts between `#[repr(..)]` hints that were previously accepted and used in practice + dangerous-implicit-autorefs deny implicit reference to a dereference of a raw pointer + default-overrides-default-fields deny detect `Default` impl that should use the type's default field values + dependency-on-unit-never-type-fallback deny never type fallback affecting unsafe function calls + deref-nullptr deny detects when an null pointer is dereferenced + elided-lifetimes-in-associated-constant deny elided lifetimes cannot be used in associated constants in impls + enum-intrinsics-non-enums deny detects calls to `core::mem::discriminant` and `core::mem::variant_count` with non-enum types + explicit-builtin-cfgs-in-flags deny detects builtin cfgs set via the `--cfg` + ill-formed-attribute-input deny ill-formed attribute inputs that were previously accepted and used in practice + incomplete-include deny trailing content in included file + ineffective-unstable-trait-impl deny detects `#[unstable]` on stable trait implementations for stable types + invalid-atomic-ordering deny usage of invalid atomic ordering in atomic operations and memory fences + invalid-from-utf8-unchecked deny using a non UTF-8 literal in `std::str::from_utf8_unchecked` + invalid-macro-export-arguments deny "invalid_parameter" isn't a valid argument for `#[macro_export]` + invalid-null-arguments deny invalid null pointer in arguments + invalid-reference-casting deny casts of `&T` to `&mut T` without interior mutability + invalid-type-param-default deny type parameter default erroneously allowed in invalid location + legacy-derive-helpers deny detects derive helper attributes that are used before they are introduced + let-underscore-lock deny non-binding let on a synchronization lock + long-running-const-eval deny detects long const eval operations + macro-expanded-macro-exports-accessed-by-absolute-paths deny macro-expanded `macro_export` macros from the current crate cannot be referred to by absolute paths + mutable-transmutes deny transmuting &T to &mut T is undefined behavior, even if the reference is unused + named-asm-labels deny named labels in inline assembly + never-type-fallback-flowing-into-unsafe deny never type fallback affecting unsafe function calls + no-mangle-const-items deny const items will not have their symbols exported + out-of-scope-macro-calls deny detects out of scope calls to `macro_rules` in key-value attributes + overflowing-literals deny literal out of range for its type + patterns-in-fns-without-body deny patterns in functions without body were erroneously allowed + proc-macro-derive-resolution-fallback deny detects proc macro derives using inaccessible names from parent modules + pub-use-of-private-extern-crate deny detect public re-exports of private extern crates + repr-transparent-non-zst-fields deny transparent type contains an external ZST that is marked #[non_exhaustive] or contains private fields + semicolon-in-expressions-from-macros deny trailing semicolon in macro body used as expression + soft-unstable deny a feature gate that doesn't break dependent crates + test-unstable-lint deny this unstable lint is only for testing + text-direction-codepoint-in-comment deny invisible directionality-changing codepoints in comment + text-direction-codepoint-in-literal deny detect special Unicode codepoints that affect the visual representation of text on screen, changing the direction in which text flows + unconditional-panic deny operation will cause a panic at runtime + undropped-manually-drops deny calls to `std::mem::drop` with `std::mem::ManuallyDrop` instead of it's inner value + unknown-crate-types deny unknown crate type found in `#[crate_type]` directive + useless-deprecated deny detects deprecation attributes with no effect + + +Lint groups provided by rustc: + + name sub-lints + ---- --------- + warnings all lints that are set to issue warnings + deprecated-safe deprecated-safe-2024 + future-incompatible aarch64-softfloat-neon, ambiguous-associated-items, ambiguous-glob-imports, ambiguous-panic-imports, coherence-leak-check, conflicting-repr-hints, const-evaluatable-unchecked, elided-lifetimes-in-associated-constant, forbidden-lint-groups, ill-formed-attribute-input, invalid-macro-export-arguments, invalid-type-param-default, late-bound-lifetime-arguments, legacy-derive-helpers, macro-expanded-macro-exports-accessed-by-absolute-paths, out-of-scope-macro-calls, patterns-in-fns-without-body, proc-macro-derive-resolution-fallback, pub-use-of-private-extern-crate, repr-c-enums-larger-than-int, repr-transparent-non-zst-fields, self-constructor-from-outer-item, semicolon-in-expressions-from-macros, soft-unstable, uncovered-param-in-projection, uninhabited-static, unstable-name-collisions, unstable-syntax-pre-expansion, unsupported-calling-conventions, varargs-without-pattern + keyword-idents keyword-idents-2018, keyword-idents-2024 + let-underscore let-underscore-drop, let-underscore-lock + nonstandard-style non-camel-case-types, non-snake-case, non-upper-case-globals + refining-impl-trait refining-impl-trait-reachable, refining-impl-trait-internal + rust-2018-compatibility keyword-idents-2018, anonymous-parameters, absolute-paths-not-starting-with-crate, tyvar-behind-raw-pointer + rust-2018-idioms bare-trait-objects, unused-extern-crates, ellipsis-inclusive-range-patterns, elided-lifetimes-in-paths, explicit-outlives-requirements + rust-2021-compatibility ellipsis-inclusive-range-patterns, array-into-iter, non-fmt-panics, bare-trait-objects, rust-2021-incompatible-closure-captures, rust-2021-incompatible-or-patterns, rust-2021-prefixes-incompatible-syntax, rust-2021-prelude-collisions + rust-2024-compatibility keyword-idents-2024, edition-2024-expr-fragment-specifier, boxed-slice-into-iter, impl-trait-overcaptures, if-let-rescope, static-mut-refs, dependency-on-unit-never-type-fallback, deprecated-safe-2024, missing-unsafe-on-extern, never-type-fallback-flowing-into-unsafe, rust-2024-guarded-string-incompatible-syntax, rust-2024-incompatible-pat, rust-2024-prelude-collisions, tail-expr-drop-order, unsafe-attr-outside-unsafe, unsafe-op-in-unsafe-fn + unknown-or-malformed-diagnostic-attributes malformed-diagnostic-attributes, malformed-diagnostic-format-literals, misplaced-diagnostic-attributes, unknown-diagnostic-attributes + unused unused-imports, unused-variables, unused-visibilities, unused-assignments, dead-code, unused-mut, unreachable-code, unreachable-patterns, unused-must-use, unused-unsafe, path-statements, unused-attributes, unused-macros, unused-macro-rules, unused-allocation, unused-doc-comments, unused-extern-crates, unused-features, unused-labels, unused-parens, unused-braces, redundant-semicolons, map-unit-fn + + +Lint tools like Clippy can load additional lints and lint groups. diff --git a/src/parse.rs b/src/parse.rs @@ -160,7 +160,7 @@ impl E<'_> { reason = "comments justifies correctness" )] fn skip_leading_space(line: &mut &[u8]) { - // The `usize` contained in the `Result` is at most `line.len()`, we indexing is fine. + // The `usize` contained in the `Result` is at most `line.len()`, so indexing is fine. *line = &line[line .iter() .try_fold(0, |idx, b| { @@ -605,12 +605,9 @@ impl<'a> Data<'a> { mod tests { use super::{Data, E, io::Read as _}; use std::fs::{self, File}; - #[expect( - clippy::assertions_on_constants, - reason = "want to pretty-print problematic file" - )] - #[expect(clippy::verbose_file_reads, reason = "want to lock file")] + #[expect(clippy::panic, reason = "want to crash when there is a bug")] #[expect(clippy::tests_outside_test_module, reason = "false positive")] + #[expect(clippy::verbose_file_reads, reason = "want to lock file")] #[test] fn outputs() { let mut output = Vec::with_capacity(u16::MAX.into()); @@ -629,8 +626,8 @@ mod tests { drop(file); let file_name = ent.file_name(); let file_name_bytes = file_name.as_encoded_bytes(); - Data::new(&output, false).map_or_else( - |e| match file_name_bytes { + if let Err(e) = Data::new(&output, false) { + match file_name_bytes { b"1.34.0.txt" | b"1.34.1.txt" | b"1.34.2.txt" => { assert_eq!( e, @@ -653,24 +650,12 @@ mod tests { ); Data::new(&output, true).is_ok() } - _ => { - assert!( - false, - "{} cannot be parsed due to {e:?}.", - String::from_utf8_lossy(file_name_bytes), - ); - false - } - }, - |_| { - if matches!(file_name_bytes, b"1.34.0.txt" | b"1.34.1.txt" | b"1.34.2.txt" | b"1.48.0.txt") { - assert!(false, "{} shouldn't be parsable", String::from_utf8_lossy(file_name_bytes)); - false - } else { - true - } - }, - ) + _ => panic!("{} cannot be parsed due to {e:?}.", String::from_utf8_lossy(file_name_bytes)), + } + } else { + assert!(!matches!(file_name_bytes, b"1.34.0.txt" | b"1.34.1.txt" | b"1.34.2.txt" | b"1.48.0.txt"), "{} shouldn't be parsable", String::from_utf8_lossy(file_name_bytes)); + true + } }) }) })