vw_small

commit 52ed8e4d7591a53b8b5445a27a2c30a00fb28074
parent db53511855146330fe251334dd769678074b31ff
Author: Daniel García <dani-garcia@users.noreply.github.com>
Date:   Sun,  7 Jun 2020 19:53:47 +0200

Merge pull request #1026 from BlackDex/issue-1022

Fixes #1022 cloning with attachments
Diffstat:
M
src/api/core/ciphers.rs
 | 
5
++++-

1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/src/api/core/ciphers.rs b/src/api/core/ciphers.rs
@@ -274,7 +274,10 @@ pub fn update_cipher_from_data(
             };
 
             if saved_att.cipher_uuid != cipher.uuid {
-                err!("Attachment is not owned by the cipher")
+                // Warn and break here since cloning ciphers provides attachment data but will not be cloned.
+                // If we error out here it will break the whole cloning and causes empty ciphers to appear.
+                warn!("Attachment is not owned by the cipher");
+                break;
             }
 
             saved_att.akey = Some(attachment.Key);